linux-kernel - Re: [PATCH v2] ACPI / PCI: fix acpi_pci_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0iG_h1k9mAfsZ5QdTA++AgfR=h5d0nH0ACVNn_AunaSwA@mail.gmail.com>
Date:   Tue, 3 Sep 2019 09:43:03 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     "Rafael J. Wysocki" <rafael@...nel.org>,
        Wenwen Wang <wenwen@...uga.edu>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>,
        "open list:PCI SUBSYSTEM" <linux-pci@...r.kernel.org>,
        "open list:ACPI" <linux-acpi@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] ACPI / PCI: fix acpi_pci_irq_enable() memory leak

On Tue, Sep 3, 2019 at 12:34 AM Bjorn Helgaas <helgaas@...nel.org> wrote:
>
> On Mon, Sep 02, 2019 at 11:19:58PM +0200, Rafael J. Wysocki wrote:
> > On Wed, Aug 21, 2019 at 5:44 AM Wenwen Wang <wenwen@...uga.edu> wrote:
> > >
> > > In acpi_pci_irq_enable(), 'entry' is allocated by kzalloc() in
> > > acpi_pci_irq_check_entry() (invoked from acpi_pci_irq_lookup()). However,
> > > it is not deallocated if acpi_pci_irq_valid() returns false, leading to a
> > > memory leak. To fix this issue, free 'entry' before returning 0.
> > >
> > > Fixes: e237a5518425 ("x86/ACPI/PCI: Recognize that Interrupt Line 255 means
> > > "not connected"")
> > >
> > > Signed-off-by: Wenwen Wang <wenwen@...uga.edu>
> >
> > Bjorn, any more comments?
>
> Nope, looks fine to me.

Thanks, queuing it up for v5.4 then.