linux-kernel - Re: [PATCH v3 4/4] edac: Add support for Amazon's Annapurna Labs L2 EDAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190903084614.mthff6hzbchkw7t2@rric.localdomain>
Date:   Tue, 3 Sep 2019 08:46:24 +0000
From:   Robert Richter <rrichter@...vell.com>
To:     "Hawa, Hanna" <hhhawa@...zon.com>
CC:     "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "bp@...en8.de" <bp@...en8.de>,
        "mchehab@...nel.org" <mchehab@...nel.org>,
        "james.morse@....com" <james.morse@....com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "Jonathan.Cameron@...wei.com" <Jonathan.Cameron@...wei.com>,
        "nicolas.ferre@...rochip.com" <nicolas.ferre@...rochip.com>,
        "paulmck@...ux.ibm.com" <paulmck@...ux.ibm.com>,
        "dwmw@...zon.co.uk" <dwmw@...zon.co.uk>,
        "benh@...zon.com" <benh@...zon.com>,
        "ronenk@...zon.com" <ronenk@...zon.com>,
        "talel@...zon.com" <talel@...zon.com>,
        "jonnyc@...zon.com" <jonnyc@...zon.com>,
        "hanochu@...zon.com" <hanochu@...zon.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>
Subject: Re: [PATCH v3 4/4] edac: Add support for Amazon's Annapurna Labs L2
 EDAC

On 03.09.19 11:28:41, Hawa, Hanna wrote:
> On 9/3/2019 10:27 AM, Robert Richter wrote:
> > On 15.07.19 16:24:09, Hanna Hawa wrote:
> > > Adds support for Amazon's Annapurna Labs L2 EDAC driver to detect and
> > > report L2 errors.
> > > 
> > > Signed-off-by: Hanna Hawa <hhhawa@...zon.com>
> > > ---
> > >   MAINTAINERS               |   6 ++
> > >   drivers/edac/Kconfig      |   8 ++
> > >   drivers/edac/Makefile     |   1 +
> > >   drivers/edac/al_l2_edac.c | 187 ++++++++++++++++++++++++++++++++++++++++++++++
> > >   4 files changed, 202 insertions(+)
> > >   create mode 100644 drivers/edac/al_l2_edac.c
> > 
> >  From a brief look at it, it seems some of my comments from 2/4 apply
> > here too. Please look through it.
> 
> Thanks for your review, will look and fix on top of v5.

I have later seen your newer versions posted which haven't made it
into my inbox. But looking at the changelog my comments are still
valid. Thanks for addressing them.

>From the changelog:

"Changes since v1:
-----------------
- Split into two drivers"

This is good, but recent practice is also to have all the drivers for
the same piece of hardware in a single file, see e.g. thunderx_edac.c.
I don't know how detailed this was discussed already, but I would
prefer to join the code.

-Robert