linux-kernel - Re: [PATCH 6/6] mfd: don't select DMA_DECLARE_COHERENT for the sm501 and tc6393xb drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20190903115133.GA3543@roeck-us.net>
Date:   Tue, 3 Sep 2019 04:51:33 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Christoph Hellwig <hch@....de>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Lee Jones <lee.jones@...aro.org>,
        Alan Stern <stern@...land.harvard.edu>,
        linux-usb@...r.kernel.org, usb-storage@...ts.one-eyed-alien.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/6] mfd: don't select DMA_DECLARE_COHERENT for the sm501
 and tc6393xb drivers

On Tue, Sep 03, 2019 at 10:46:15AM +0200, Christoph Hellwig wrote:
> Now that these drivers use the usb localmem pool there is no need to
> select DMA_DECLARE_COHERENT.
> 
> Signed-off-by: Christoph Hellwig <hch@....de>

Tested-by: Guenter Roeck <linux@...ck-us.net>

for SM501.

> ---
>  drivers/mfd/Kconfig | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index f129f9678940..c8cbde59bbf6 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -1105,7 +1105,6 @@ config MFD_SI476X_CORE
>  config MFD_SM501
>  	tristate "Silicon Motion SM501"
>  	depends on HAS_DMA
> -	select DMA_DECLARE_COHERENT
>  	 ---help---
>  	  This is the core driver for the Silicon Motion SM501 multimedia
>  	  companion chip. This device is a multifunction device which may
> @@ -1714,7 +1713,6 @@ config MFD_TC6393XB
>  	select GPIOLIB
>  	select MFD_CORE
>  	select MFD_TMIO
> -	select DMA_DECLARE_COHERENT
>  	help
>  	  Support for Toshiba Mobile IO Controller TC6393XB
>  
> -- 
> 2.20.1
>