linux-kernel - Re: [PATCH -next] usb: typec: tps6598x: Fix build error without CONFIG_REGMAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190903122149.GB23603@kuha.fi.intel.com>
Date:   Tue, 3 Sep 2019 15:21:49 +0300
From:   Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] usb: typec: tps6598x: Fix build error without
 CONFIG_REGMAP_I2C

On Tue, Sep 03, 2019 at 08:10:26PM +0800, YueHaibing wrote:
> If CONFIG_REGMAP_I2C is not set, building fails:
> 
> drivers/usb/typec/tps6598x.o: In function `tps6598x_probe':
> tps6598x.c:(.text+0x5f0): undefined reference to `__devm_regmap_init_i2c'
> 
> Select REGMAP_I2C to fix this.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Fixes: 0a4c005bd171 ("usb: typec: driver for TI TPS6598x USB Power Delivery controllers")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Acked-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

> ---
>  drivers/usb/typec/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/typec/Kconfig b/drivers/usb/typec/Kconfig
> index 89d9193..895e241 100644
> --- a/drivers/usb/typec/Kconfig
> +++ b/drivers/usb/typec/Kconfig
> @@ -53,6 +53,7 @@ source "drivers/usb/typec/ucsi/Kconfig"
>  config TYPEC_TPS6598X
>  	tristate "TI TPS6598x USB Power Delivery controller driver"
>  	depends on I2C
> +	select REGMAP_I2C
>  	help
>  	  Say Y or M here if your system has TI TPS65982 or TPS65983 USB Power
>  	  Delivery controller.
> -- 
> 2.7.4
> 

thanks,

-- 
heikki