linux-kernel - Re: [PATCH] brcmfmac: replace strncpy() by strscpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190903134351.65443602CA@smtp.codeaurora.org>
Date:   Tue,  3 Sep 2019 13:43:51 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Xulin Sun <xulin.sun@...driver.com>
Cc:     <stefan.wahren@...e.com>, <xulin.sun@...driver.com>,
        <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
        <brcm80211-dev-list@...ress.com>,
        <brcm80211-dev-list.pdl@...adcom.com>,
        <linux-wireless@...r.kernel.org>, <arend.vanspriel@...adcom.com>,
        <franky.lin@...adcom.com>, <hante.meuleman@...adcom.com>,
        <chi-hsien.lin@...ress.com>, <wright.feng@...ress.com>,
        <davem@...emloft.net>, <stanley.hsu@...ress.com>
Subject: Re: [PATCH] brcmfmac: replace strncpy() by strscpy()

Xulin Sun <xulin.sun@...driver.com> wrote:

> The strncpy() may truncate the copied string,
> replace it by the safer strscpy().
> 
> To avoid below compile warning with gcc 8.2:
> 
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:In function 'brcmf_vndr_ie':
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:4227:2:
> warning: 'strncpy' output truncated before terminating nul copying 3 bytes from a string of the same length [-Wstringop-truncation]
>   strncpy(iebuf, add_del_cmd, VNDR_IE_CMD_LEN - 1);
>   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Signed-off-by: Xulin Sun <xulin.sun@...driver.com>
> Acked-by: Arend van Spriel <arend.vanspriel@...adcom.com>

Patch applied to wireless-drivers-next.git, thanks.

5f42b382ead2 brcmfmac: replace strncpy() by strscpy()

-- 
https://patchwork.kernel.org/patch/11110841/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches