linux-kernel - Re: [PATCH] hwmon: fix devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 3 Sep 2019 07:05:15 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Julia Lawall <julia.lawall@...6.fr>
Cc:     Jisheng Zhang <Jisheng.Zhang@...aptics.com>,
        Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org,
        linux-kernel@...r.kernel.org, kbuild-all@...org
Subject: Re: [PATCH] hwmon: fix devm_platform_ioremap_resource.cocci warnings

On Tue, Sep 03, 2019 at 06:47:52AM +0200, Julia Lawall wrote:
> From: kbuild test robot <lkp@...el.com>
> 
>  Use devm_platform_ioremap_resource helper which wraps
>  platform_get_resource() and devm_ioremap_resource() together.
> 
> Generated by: scripts/coccinelle/api/devm_platform_ioremap_resource.cocci
> 
> Fixes: 658e687b4218 ("hwmon: Add Synaptics AS370 PVT sensor driver")
> CC: Jisheng Zhang <Jisheng.Zhang@...aptics.com>
> Signed-off-by: kbuild test robot <lkp@...el.com>
> Signed-off-by: Julia Lawall <julia.lawall@...6.fr>
> Reviewed-by: Jisheng Zhang <Jisheng.Zhang@...aptics.com>

Applied to hwmon-next.

Thanks,
Guenter

> ---
> 
> tree:   https://kernel.googlesource.com/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
> head:   9c551fac9ea9629cdc6deb205292c2bbe7b38917
> commit: 658e687b4218b42d03a5b0b79a292c9c48f1ddaf [32/34] hwmon: Add Synaptics AS370 PVT sensor driver
> :::::: branch date: 7 hours ago
> :::::: commit date: 7 hours ago
> 
> Please take the patch only if it's a positive warning. Thanks!
> 
>  as370-hwmon.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> --- a/drivers/hwmon/as370-hwmon.c
> +++ b/drivers/hwmon/as370-hwmon.c
> @@ -103,7 +103,6 @@ static const struct hwmon_chip_info as37
> 
>  static int as370_hwmon_probe(struct platform_device *pdev)
>  {
> -	struct resource *res;
>  	struct device *hwmon_dev;
>  	struct as370_hwmon *hwmon;
>  	struct device *dev = &pdev->dev;
> @@ -112,8 +111,7 @@ static int as370_hwmon_probe(struct plat
>  	if (!hwmon)
>  		return -ENOMEM;
> 
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	hwmon->base = devm_ioremap_resource(&pdev->dev, res);
> +	hwmon->base = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(hwmon->base))
>  		return PTR_ERR(hwmon->base);