linux-kernel - Re: [PATCH] ocfs2: Delete unnecessary checks before brelse()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <153d9e24-d79d-1ba6-da5f-824ec9d8070a@linux.alibaba.com>
Date:   Tue, 3 Sep 2019 22:56:30 +0800
From:   Joseph Qi <joseph.qi@...ux.alibaba.com>
To:     Markus Elfring <Markus.Elfring@....de>, ocfs2-devel@....oracle.com,
        Joel Becker <jlbec@...lplan.org>, Mark Fasheh <mark@...heh.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Jia-Ju Bai <baijiaju1990@...il.com>,
        Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH] ocfs2: Delete unnecessary checks before brelse()



On 19/9/3 22:40, Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Tue, 3 Sep 2019 16:33:32 +0200
> 
> The brelse() function tests whether its argument is NULL
> and then returns immediately.
> Thus the tests around the shown calls are not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

Reviewed-by: Joseph Qi <joseph.qi@...ux.alibaba.com>
> ---
>  fs/ocfs2/dlmglue.c    | 7 ++-----
>  fs/ocfs2/extent_map.c | 3 +--
>  2 files changed, 3 insertions(+), 7 deletions(-)
> 
> diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c
> index ad594fef2ab0..6e774c5ea13b 100644
> --- a/fs/ocfs2/dlmglue.c
> +++ b/fs/ocfs2/dlmglue.c
> @@ -2508,9 +2508,7 @@ int ocfs2_inode_lock_full_nested(struct inode *inode,
>  			ocfs2_inode_unlock(inode, ex);
>  	}
> 
> -	if (local_bh)
> -		brelse(local_bh);
> -
> +	brelse(local_bh);
>  	return status;
>  }
> 
> @@ -2593,8 +2591,7 @@ int ocfs2_inode_lock_atime(struct inode *inode,
>  		*level = 1;
>  		if (ocfs2_should_update_atime(inode, vfsmnt))
>  			ocfs2_update_inode_atime(inode, bh);
> -		if (bh)
> -			brelse(bh);
> +		brelse(bh);
>  	} else
>  		*level = 0;
> 
> diff --git a/fs/ocfs2/extent_map.c b/fs/ocfs2/extent_map.c
> index e66a249fe07c..e3e2d1b2af51 100644
> --- a/fs/ocfs2/extent_map.c
> +++ b/fs/ocfs2/extent_map.c
> @@ -590,8 +590,7 @@ int ocfs2_xattr_get_clusters(struct inode *inode, u32 v_cluster,
>  			*extent_flags = rec->e_flags;
>  	}
>  out:
> -	if (eb_bh)
> -		brelse(eb_bh);
> +	brelse(eb_bh);
>  	return ret;
>  }
> 
> --
> 2.23.0
>