linux-kernel - RE: [PATCH V2 2/5] input: keyboard: imx_sc: Add i.MX system controller power key support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB3PR0402MB391636D31F486639FB8B3BA6F5B90@DB3PR0402MB3916.eurprd04.prod.outlook.com>
Date:   Tue, 3 Sep 2019 03:11:35 +0000
From:   Anson Huang <anson.huang@....com>
To:     Fabio Estevam <festevam@...il.com>
CC:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Sascha Hauer <kernel@...gutronix.de>,
        Catalin Marinas <catalin.marinas@....com>,
        "will@...nel.org" <will@...nel.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Aisheng Dong <aisheng.dong@....com>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Andy Duan <fugang.duan@....com>, Peng Fan <peng.fan@....com>,
        Daniel Baluta <daniel.baluta@....com>,
        Leonard Crestez <leonard.crestez@....com>,
        "mripard@...nel.org" <mripard@...nel.org>,
        Olof Johansson <olof@...om.net>, Arnd Bergmann <arnd@...db.de>,
        Jagan Teki <jagan@...rulasolutions.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Dinh Nguyen <dinguyen@...nel.org>,
        "marcin.juszkiewicz@...aro.org" <marcin.juszkiewicz@...aro.org>,
        Stefan Agner <stefan@...er.ch>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        "yuehaibing@...wei.com" <yuehaibing@...wei.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        "ronald@...ovation.ch" <ronald@...ovation.ch>,
        Marco Felsch <m.felsch@...gutronix.de>,
        Jacky Bai <ping.bai@....com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH V2 2/5] input: keyboard: imx_sc: Add i.MX system
 controller power key support

Hi, Fabio

> On Mon, Sep 2, 2019 at 11:05 PM Anson Huang <Anson.Huang@....com>
> wrote:
> 
> > +       ret = input_register_device(input);
> > +       if (ret < 0) {
> > +               dev_err(&pdev->dev, "failed to register input device\n");
> > +               return ret;
> > +       }
> > +
> > +       pdata->input = input;
> > +       platform_set_drvdata(pdev, pdata);
> > +
> > +       ret = imx_scu_irq_group_enable(SC_IRQ_GROUP_WAKE,
> SC_IRQ_BUTTON, true);
> > +       if (ret) {
> > +               dev_warn(&pdev->dev, "enable scu group irq failed\n");
> > +               return ret;
> 
> Better do a 'goto input_unregister' here instead and call
> input_unregister_device().

Agreed, will fix in V3 later.

Thanks,
Anson.