linux-kernel - Re: [PATCH 4.9 07/83] ASoC: Fail card instantiation if DAI format setup fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190904183527.GA364@kroah.com>
Date:   Wed, 4 Sep 2019 20:35:27 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Mark Brown <broonie@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Ricard Wanderlof <ricardw@...s.com>,
        Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH 4.9 07/83] ASoC: Fail card instantiation if DAI format
 setup fails

On Wed, Sep 04, 2019 at 07:10:27PM +0100, Mark Brown wrote:
> On Wed, Sep 04, 2019 at 07:52:59PM +0200, Greg Kroah-Hartman wrote:
> > [ Upstream commit 40aa5383e393d72f6aa3943a4e7b1aae25a1e43b ]
> > 
> > If the DAI format setup fails, there is no valid communication format
> > between CPU and CODEC, so fail card instantiation, rather than continue
> > with a card that will most likely not function properly.
> 
> I nacked this patch when Sasha posted it - it only improves diagnostics
> and might make systems that worked by accident break since it turns 
> things into a hard failure, it won't make anything that didn't work
> previously work.

This is already in the 4.14.141, 4.19.69, and 5.2.11 releases, have you
heard any problems there?

I'll be glad to drop this from the 4.9.y and 4.4.y queues, now if you
wish, but just want you to know it's already out there in some releases.

thanks,

greg k-h