linux-kernel - Re: [PATCH -next] scsi: ufs-hisi: use devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 05 Sep 2019 01:19:27 +0530
From:   Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
To:     YueHaibing <yuehaibing@...wei.com>, alim.akhtar@...sung.com,
        avri.altman@....com, pedrom.sousa@...opsys.com, jejb@...ux.ibm.com,
        martin.petersen@...cle.com, liwei213@...wei.com,
        dimitrysh@...gle.com, kjlu@....edu, tglx@...utronix.de,
        yuehaibing@...wei.com, stanley.chu@...iatek.com, arnd@...db.de
CC:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] scsi: ufs-hisi: use devm_platform_ioremap_resource() to simplify code



On 4 September 2019 6:34:57 PM IST, YueHaibing <yuehaibing@...wei.com> wrote:
>Use devm_platform_ioremap_resource() to simplify the code a bit.
>This is detected by coccinelle.
>
>Reported-by: Hulk Robot <hulkci@...wei.com>
>Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>

Thanks, 
Mani
>---
> drivers/scsi/ufs/ufs-hisi.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
>diff --git a/drivers/scsi/ufs/ufs-hisi.c b/drivers/scsi/ufs/ufs-hisi.c
>index f4d1dca..6bbb167 100644
>--- a/drivers/scsi/ufs/ufs-hisi.c
>+++ b/drivers/scsi/ufs/ufs-hisi.c
>@@ -447,13 +447,11 @@ static int ufs_hisi_resume(struct ufs_hba *hba,
>enum ufs_pm_op pm_op)
> 
> static int ufs_hisi_get_resource(struct ufs_hisi_host *host)
> {
>-	struct resource *mem_res;
> 	struct device *dev = host->hba->dev;
> 	struct platform_device *pdev = to_platform_device(dev);
> 
> 	/* get resource of ufs sys ctrl */
>-	mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
>-	host->ufs_sys_ctrl = devm_ioremap_resource(dev, mem_res);
>+	host->ufs_sys_ctrl = devm_platform_ioremap_resource(pdev, 1);
> 	if (IS_ERR(host->ufs_sys_ctrl))
> 		return PTR_ERR(host->ufs_sys_ctrl);
> 

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.