linux-kernel - Re: [PATCH 0/8] tools-power-x86-intel-speed-select: Fixes and updates for output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e6390a656dfd29b114b1e0659e3db169344cfa81.camel@linux.intel.com>
Date:   Wed, 04 Sep 2019 13:06:29 -0700
From:   Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
To:     Prarit Bhargava <prarit@...hat.com>,
        platform-driver-x86@...r.kernel.org,
        Andy Shevchenko <andriy.shevchenko@...el.com>
Cc:     David Arcari <darcari@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/8] tools-power-x86-intel-speed-select: Fixes and
 updates for output

On Tue, 2019-09-03 at 11:37 -0400, Prarit Bhargava wrote:
> Some general fixes and updates for intel-speed-select.  Fixes include
> some
> typos as well as an off-by-one cpu count reporting error.  Updates
> for the
> output are
> 
> - switching to MHz as a standard
> - reporting CPU frequencies instead of ratios as a standard
> - viewing a human-readable CPU list.
> - avoiding reporting "0|1" as success|fail as these can be confusing
> for a
>   user.
Series looks fine, except 8/8.
So please submit v2. Better to resubmit as a series as v2, unless Andy
has other preference.

Thanks,
Srinivas

> 
> Signed-off-by: Prarit Bhargava <prarit@...hat.com>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
> Cc: David Arcari <darcari@...hat.com>
> Cc: linux-kernel@...r.kernel.org
> 
> Prarit Bhargava (8):
>   tools/power/x86/intel-speed-select: Fix package typo
>   tools/power/x86/intel-speed-select: Fix help option typo
>   tools/power/x86/intel-speed-select: Fix cpu-count output
>   tools/power/x86/intel-speed-select: Simplify output for turbo-freq
> and
>     base-freq
>   tools/power/x86/intel-speed-select: Switch output to MHz
>   tools/power/x86/intel-speed-select: Change turbo ratio output to
>     maximum turbo frequency
>   tools/power/x86/intel-speed-select: Output human readable CPU list
>   tools/power/x86/intel-speed-select: Output success/failed for
> command
>     output
> 
>  .../x86/intel-speed-select/isst-config.c      |   4 +-
>  .../x86/intel-speed-select/isst-display.c     | 116 ++++++++++++--
> ----
>  2 files changed, 83 insertions(+), 37 deletions(-)
>