linux-kernel - Re: WARNING in hso_free_net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190904154140.45dfb398@hermes.lan>
Date:   Wed, 4 Sep 2019 15:41:40 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Hui Peng <benquike@...il.com>
Cc:     syzbot+44d53c7255bb1aea22d2@...kaller.appspotmail.com,
        alexios.zavras@...el.com, andreyknvl@...gle.com,
        davem@...emloft.net, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
        mathias.payer@...elwelt.net, netdev@...r.kernel.org,
        rfontana@...hat.com, syzkaller-bugs@...glegroups.com,
        tglx@...utronix.de
Subject: Re: WARNING in hso_free_net_device

On Wed, 4 Sep 2019 16:27:50 -0400
Hui Peng <benquike@...il.com> wrote:

> Hi, all:
> 
> I looked at the bug a little.
> 
> The issue is that in the error handling code, hso_free_net_device
> unregisters
> 
> the net_device (hso_net->net)  by calling unregister_netdev. In the
> error handling code path,
> 
> hso_net->net has not been registered yet.
> 
> I think there are two ways to solve the issue:
> 
> 1. fix it in drivers/net/usb/hso.c to avoiding unregistering the
> net_device when it is still not registered
> 
> 2. fix it in unregister_netdev. We can add a field in net_device to
> record whether it is registered, and make unregister_netdev return if
> the net_device is not registered yet.
> 
> What do you guys think ?

#1