linux-kernel - Re: [PATCH][next] net/mlx5: fix missing assignment of variable err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <16073125f6bbc617a9ddc77441b9d3b840d50e28.camel@mellanox.com>
Date:   Wed, 4 Sep 2019 23:30:48 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        Maor Gottlieb <maorg@...lanox.com>,
        "colin.king@...onical.com" <colin.king@...onical.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "leon@...nel.org" <leon@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][next] net/mlx5: fix missing assignment of variable err

On Wed, 2019-09-04 at 20:29 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The error return from a call to mlx5_flow_namespace_set_peer is not
> being assigned to variable err and hence the error check following
> the call is currently not working.  Fix this by assigning ret as
> intended.
> 
> Addresses-Coverity: ("Logically dead code")
> Fixes: 8463daf17e80 ("net/mlx5: Add support to use SMFS in switchdev
> mode")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---

Applied to net-next-mlx5.

I have a cleanup series coming up, will send it all together to 
net-next soon. 

Thanks,
Saeed.