linux-kernel - Re: [PATCH] i2c: cht-wc: drop check because i2c_unregister

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2e55f3cb-ba88-5404-3b38-585710976ed0@redhat.com>
Date:   Wed, 4 Sep 2019 10:26:30 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Wolfram Sang <wsa@...-dreams.de>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>
Cc:     linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: cht-wc: drop check because i2c_unregister_device()
 is NULL safe

Hi,

On 03-09-19 19:52, Wolfram Sang wrote:
> On Tue, Aug 20, 2019 at 05:34:40PM +0200, Wolfram Sang wrote:
>> No need to check the argument of i2c_unregister_device() because the
>> function itself does it.
>>
>> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
>> ---
> 
> Hans, are you OK with this change?

Yes this is fine by me:

Acked-by: Hans de Goede <hdegoede@...hat.com>

Regards,

Hans


> 
>> Build tested only, buildbot is happy, too.
>>
>> Please apply to your tree.
>>
>>   drivers/i2c/busses/i2c-cht-wc.c | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/i2c/busses/i2c-cht-wc.c b/drivers/i2c/busses/i2c-cht-wc.c
>> index 66af44bfa67d..3e2608a65c06 100644
>> --- a/drivers/i2c/busses/i2c-cht-wc.c
>> +++ b/drivers/i2c/busses/i2c-cht-wc.c
>> @@ -363,8 +363,7 @@ static int cht_wc_i2c_adap_i2c_remove(struct platform_device *pdev)
>>   {
>>   	struct cht_wc_i2c_adap *adap = platform_get_drvdata(pdev);
>>   
>> -	if (adap->client)
>> -		i2c_unregister_device(adap->client);
>> +	i2c_unregister_device(adap->client);
>>   	i2c_del_adapter(&adap->adapter);
>>   	irq_domain_remove(adap->irq_domain);
>>   
>> -- 
>> 2.20.1
>>