linux-kernel - Re: [PATCH] soundwire: slave: Fix unused function warning on !ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190904124803.1700a65a@naga>
Date:   Wed, 4 Sep 2019 12:48:03 +0200
From:   Michal Suchánek <msuchanek@...e.de>
To:     Vinod Koul <vkoul@...nel.org>
Cc:     Randy Dunlap <rdunlap@...radead.org>, alsa-devel@...a-project.org,
        Sanyog Kale <sanyog.r.kale@...el.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] soundwire: slave: Fix unused function warning on !ACPI

On Wed, 4 Sep 2019 15:00:52 +0530
Vinod Koul <vkoul@...nel.org> wrote:

> On 30-08-19, 11:56, Randy Dunlap wrote:
> > On 8/30/19 11:52 AM, Michal Suchanek wrote:  
> > > Fixes the following warning on !ACPI systems:
> > > 
> > > drivers/soundwire/slave.c:16:12: warning: ‘sdw_slave_add’ defined but
> > > not used [-Wunused-function]
> > >  static int sdw_slave_add(struct sdw_bus *bus,
> > >             ^~~~~~~~~~~~~
> > > 
> > > Signed-off-by: Michal Suchanek <msuchanek@...e.de>  
> > 
> > Acked-by: Randy Dunlap <rdunlap@...radead.org>
> > 
> > I was about to send the same patch.  
> 
> So I have applied Srini's patches which add DT support and they use
> sdw_slave_add(). So next tomorrow should not see this error as it is now
> used by DT parts as well.
> 
> So dropping this patch
> 

That should fix the issue for me. I wonder if !ACPI !DT platforms are
still a thing.

Thanks

Michal