linux-kernel - Re: [PATCH v3] sched/core: Fix uclamp ABI bug, clean up and robustify sched_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <43e9f6ae-7ebc-d3d8-eecf-860cdef7fdec@arm.com>
Date:   Wed, 4 Sep 2019 12:55:33 +0200
From:   Dietmar Eggemann <dietmar.eggemann@....com>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     Thadeu Lima de Souza Cascardo <cascardo@...onical.com>,
        linux-kernel@...r.kernel.org,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Patrick Bellasi <patrick.bellasi@....com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Arnaldo Carvalho de Melo <acme@...radead.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Jiri Olsa <jolsa@...hat.com>
Subject: Re: [PATCH v3] sched/core: Fix uclamp ABI bug, clean up and robustify
 sched_read_attr() ABI logic and code

On 04/09/2019 12:39, Ingo Molnar wrote:
> 
> * Dietmar Eggemann <dietmar.eggemann@....com> wrote:
> 
>>> -v3 attached. Build and minimally boot tested.
>>>
>>> Thanks,
>>>
>>> 	Ingo
>>>
>>
>> This patch fixes the issue (almost).
>>
>> LTP's sched_getattr01 passes again. But IMHO the prio 'chrt -p $$'
>> should be 0 instead of -65536.
> 
> Yeah, I forgot to zero-initialize the structure ...
> 
> Does the attached -v4 work any better for you?

Yeah, looks better now.

# chrt -p $$
[  258.245786] sched_attr_copy_to_user(): copied 48 bytes. (ksize: 56,
usize: 48)
pid 1635's current scheduling policy: SCHED_OTHER
pid 1635's current scheduling priority: 0

w/o the extra printk:

Tested-by: Dietmar Eggemann <dietmar.eggemann@....com>