linux-kernel - Re: [PATCH RFC 2/2] interconnect: qcom: add msm8974 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8f1a25aa-6dc6-b94a-fc58-e944bdfae939@free.fr>
Date:   Wed, 4 Sep 2019 13:10:08 +0200
From:   Marc Gonzalez <marc.w.gonzalez@...e.fr>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>,
        Brian Masney <masneyb@...tation.org>
Cc:     Georgi Djakov <georgi.djakov@...aro.org>,
        MSM <linux-arm-msm@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RFC 2/2] interconnect: qcom: add msm8974 driver

On 04/09/2019 07:39, Bjorn Andersson wrote:

> On Mon 02 Sep 14:19 PDT 2019, Brian Masney wrote:
> 
>> +DEFINE_QNODE(mas_ampss_m0, MSM8974_BIMC_MAS_AMPSS_M0, 8, 0, -1);
>> +DEFINE_QNODE(mas_ampss_m1, MSM8974_BIMC_MAS_AMPSS_M1, 8, 0, -1);
>> +DEFINE_QNODE(mas_mss_proc, MSM8974_BIMC_MAS_MSS_PROC, 8, 1, -1);
>> +DEFINE_QNODE(bimc_to_mnoc, MSM8974_BIMC_TO_MNOC, 8, 2, -1,
>> +	     MSM8974_BIMC_SLV_EBI_CH0);
> 
> None of these looks excessive, so please ignore the 80-char rule to
> improve readability.

Indeed!