linux-kernel - Re: [PATCH 2/2] KVM: SVM: Disable posted interrupts for odd IRQs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ff1bad8b-31dc-042b-7b90-ccc31e1a80de@amazon.com>
Date:   Wed, 4 Sep 2019 15:06:05 +0200
From:   Alexander Graf <graf@...zon.com>
To:     Liran Alon <liran.alon@...cle.com>
CC:     kvm list <kvm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <x86@...nel.org>, "H. Peter Anvin" <hpa@...or.com>,
        Borislav Petkov <bp@...en8.de>, Ingo Molnar <mingo@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Joerg Roedel <joro@...tes.org>,
        Jim Mattson <jmattson@...gle.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Sean Christopherson <sean.j.christopherson@...el.com>,
        Radim Krčmář <rkrcmar@...hat.com>,
        Paolo Bonzini <pbonzini@...hat.com>
Subject: Re: [PATCH 2/2] KVM: SVM: Disable posted interrupts for odd IRQs



On 04.09.19 01:20, Liran Alon wrote:
> 
> 
>> On 3 Sep 2019, at 17:29, Alexander Graf <graf@...zon.com> wrote:
>>
>> We can easily route hardware interrupts directly into VM context when
>> they target the "Fixed" or "LowPriority" delivery modes.
>>
>> However, on modes such as "SMI" or "Init", we need to go via KVM code
>> to actually put the vCPU into a different mode of operation, so we can
>> not post the interrupt
>>
>> Add code in the SVM PI logic to explicitly refuse to establish posted
>> mappings for advanced IRQ deliver modes.
>>
>> This fixes a bug I have with code which configures real hardware to
>> inject virtual SMIs into my guest.
>>
>> Signed-off-by: Alexander Graf <graf@...zon.com>
> 
> Nit: I prefer to squash both commits into one that change both VMX & SVM.
> As it’s exactly the same change.

It's the same change (hence the same patch set), but they touch 
different files and so for bisectability it's still convenient to have 
them as different commits. I'd really prefer to have them stay separate.

Thanks a lot for the review! :)


Alex



Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Ralf Herbrich
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879