linux-kernel - Re: [PATCH -next] scsi: hisi_sas: use devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <adab136f-330e-1ce5-2a43-f2e19ed7e92d@huawei.com>
Date:   Wed, 4 Sep 2019 14:44:38 +0100
From:   John Garry <john.garry@...wei.com>
To:     YueHaibing <yuehaibing@...wei.com>, <jejb@...ux.ibm.com>,
        <martin.petersen@...cle.com>
CC:     <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] scsi: hisi_sas: use
 devm_platform_ioremap_resource() to simplify code

On 04/09/2019 14:02, YueHaibing wrote:
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
>
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Acked-by: John Garry <john.garry@...wei.com>

> ---
>  drivers/scsi/hisi_sas/hisi_sas_main.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c
> index d60eaaa..d34e398 100644
> --- a/drivers/scsi/hisi_sas/hisi_sas_main.c
> +++ b/drivers/scsi/hisi_sas/hisi_sas_main.c
> @@ -2579,8 +2579,7 @@ static struct Scsi_Host *hisi_sas_shost_alloc(struct platform_device *pdev,
>  		goto err_out;
>  	}
>
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	hisi_hba->regs = devm_ioremap_resource(dev, res);
> +	hisi_hba->regs = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(hisi_hba->regs))
>  		goto err_out;
>
>