linux-kernel - Re: [PATCH v1] bluetooth: hci_qca: disable irqs when spinlock is acquired

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <6F34A9CD-7C8F-4E5D-9A22-9F05CC2CF9BC@holtmann.org>
Date:   Wed, 4 Sep 2019 16:06:53 +0200
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Harish Bandi <c-hbandi@...eaurora.org>
Cc:     Johan Hedberg <johan.hedberg@...il.com>, mka@...omium.org,
        linux-kernel@...r.kernel.org, linux-bluetooth@...r.kernel.org,
        hemantg@...eaurora.org, linux-arm-msm@...r.kernel.org,
        bgodavar@...eaurora.org, anubhavg@...eaurora.org
Subject: Re: [PATCH v1] bluetooth: hci_qca: disable irqs when spinlock is
 acquired

Hi Harish,

> Looks like Deadlock is observed in hci_qca while performing
> stress and stability tests. Since same lock is getting
> acquired from qca_wq_awake_rx and hci_ibs_tx_idle_timeout
> seeing spinlock recursion, irqs should be disable while
> acquiring the spinlock always.
> 
> Signed-off-by: Harish Bandi <c-hbandi@...eaurora.org>
> ---
> drivers/bluetooth/hci_qca.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)

patch has been applied to bluetooth-stable tree.

Regards

Marcel