linux-kernel - Re: [PATCH -next 16/36] spi: spi-meson-spifc: use devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f4afcae3-8796-2ce4-0377-918536d5bf3e@baylibre.com>
Date:   Wed, 4 Sep 2019 16:14:12 +0200
From:   Neil Armstrong <narmstrong@...libre.com>
To:     YueHaibing <yuehaibing@...wei.com>, broonie@...nel.org,
        f.fainelli@...il.com, rjui@...adcom.com, sbranden@...adcom.com,
        eric@...olt.net, wahrenst@....net, shc_work@...l.ru,
        agross@...nel.org, khilman@...libre.com, matthias.bgg@...il.com,
        shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
        festevam@...il.com, linux-imx@....com, avifishman70@...il.com,
        tmaimon77@...il.com, tali.perry1@...il.com, venture@...gle.com,
        yuenn@...gle.com, benjaminfair@...gle.com, kgene@...nel.org,
        krzk@...nel.org, andi@...zian.org, palmer@...ive.com,
        paul.walmsley@...ive.com, baohua@...nel.org, mripard@...nel.org,
        wens@...e.org, ldewangan@...dia.com, thierry.reding@...il.com,
        jonathanh@...dia.com, yamada.masahiro@...ionext.com,
        michal.simek@...inx.com
Cc:     linux-samsung-soc@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        openbmc@...ts.ozlabs.org, linux-mediatek@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-spi@...r.kernel.org,
        bcm-kernel-feedback-list@...adcom.com,
        linux-rpi-kernel@...ts.infradead.org, linux-tegra@...r.kernel.org,
        linux-amlogic@...ts.infradead.org, linux-riscv@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH -next 16/36] spi: spi-meson-spifc: use
 devm_platform_ioremap_resource() to simplify code

On 04/09/2019 15:58, YueHaibing wrote:
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/spi/spi-meson-spifc.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/spi/spi-meson-spifc.c b/drivers/spi/spi-meson-spifc.c
> index f7fe9b1..c7b0399 100644
> --- a/drivers/spi/spi-meson-spifc.c
> +++ b/drivers/spi/spi-meson-spifc.c
> @@ -286,7 +286,6 @@ static int meson_spifc_probe(struct platform_device *pdev)
>  {
>  	struct spi_master *master;
>  	struct meson_spifc *spifc;
> -	struct resource *res;
>  	void __iomem *base;
>  	unsigned int rate;
>  	int ret = 0;
> @@ -300,8 +299,7 @@ static int meson_spifc_probe(struct platform_device *pdev)
>  	spifc = spi_master_get_devdata(master);
>  	spifc->dev = &pdev->dev;
>  
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	base = devm_ioremap_resource(spifc->dev, res);
> +	base = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(base)) {
>  		ret = PTR_ERR(base);
>  		goto out_err;
> 

Reviewed-by: Neil Armstrong <narmstrong@...libre.com>