linux-kernel - Re: [PATCH] pinctrl: qcom: sdm845: Fix UFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190904041042.GA3081@tuxbook-pro>
Date:   Tue, 3 Sep 2019 21:10:42 -0700
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Stephen Boyd <swboyd@...omium.org>
Cc:     linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-gpio@...r.kernel.org,
        Linus Walleij <linus.walleij@...aro.org>,
        Andy Gross <agross@...nel.org>
Subject: Re: [PATCH] pinctrl: qcom: sdm845: Fix UFS_RESET pin

On Thu 29 Aug 23:02 PDT 2019, Stephen Boyd wrote:

> The UFS_RESET pin is the magical pin #150 now, not 153 per the
> sdm845_groups array declared in this file. Fix the order of pins so that
> UFS_RESET is 150 and the SDC pins follow after.
> 

Woops, thanks

Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>

> Fixes: 53a5372ce326 ("pinctrl: qcom: sdm845: Expose ufs_reset as gpio")
> Signed-off-by: Stephen Boyd <swboyd@...omium.org>
> ---
>  drivers/pinctrl/qcom/pinctrl-sdm845.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/pinctrl/qcom/pinctrl-sdm845.c b/drivers/pinctrl/qcom/pinctrl-sdm845.c
> index 39f498c09906..ce495970459d 100644
> --- a/drivers/pinctrl/qcom/pinctrl-sdm845.c
> +++ b/drivers/pinctrl/qcom/pinctrl-sdm845.c
> @@ -262,10 +262,10 @@ static const struct pinctrl_pin_desc sdm845_pins[] = {
>  	PINCTRL_PIN(147, "GPIO_147"),
>  	PINCTRL_PIN(148, "GPIO_148"),
>  	PINCTRL_PIN(149, "GPIO_149"),
> -	PINCTRL_PIN(150, "SDC2_CLK"),
> -	PINCTRL_PIN(151, "SDC2_CMD"),
> -	PINCTRL_PIN(152, "SDC2_DATA"),
> -	PINCTRL_PIN(153, "UFS_RESET"),
> +	PINCTRL_PIN(150, "UFS_RESET"),
> +	PINCTRL_PIN(151, "SDC2_CLK"),
> +	PINCTRL_PIN(152, "SDC2_CMD"),
> +	PINCTRL_PIN(153, "SDC2_DATA"),
>  };
>  
>  #define DECLARE_MSM_GPIO_PINS(pin) \
> -- 
> Sent by a computer through tubes
>