linux-kernel - NAK: [PATCH] media: cxd2820r: make array tab static const, makes object smaller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7b9c9aea-9cb9-cd9e-871d-1585ada2993c@canonical.com>
Date:   Thu, 5 Sep 2019 18:50:32 +0100
From:   Colin Ian King <colin.king@...onical.com>
To:     Antti Palosaari <crope@....fi>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: NAK: [PATCH] media: cxd2820r: make array tab static const, makes
 object smaller

There are a few more arrays in these drivers than can be fixed up, I'll
send a V2.


On 05/09/2019 18:45, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Don't populate the array tab on the stack but instead make it
> static const. Makes the object code smaller by 53 bytes.
> 
> Before:
>    text	   data	    bss	    dec	    hex	filename
>    7045	   1736	      0	   8781	   224d	media/dvb-frontends/cxd2820r_c.o
> 
> After:
>    text	   data	    bss	    dec	    hex	filename
>    6896	   1832	      0	   8728	   2218	media/dvb-frontends/cxd2820r_c.o
> 
> (gcc version 9.2.1, amd64)
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/media/dvb-frontends/cxd2820r_c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/dvb-frontends/cxd2820r_c.c b/drivers/media/dvb-frontends/cxd2820r_c.c
> index 6f7eedb4c00e..0ba382948c51 100644
> --- a/drivers/media/dvb-frontends/cxd2820r_c.c
> +++ b/drivers/media/dvb-frontends/cxd2820r_c.c
> @@ -298,7 +298,7 @@ int cxd2820r_sleep_c(struct dvb_frontend *fe)
>  	struct cxd2820r_priv *priv = fe->demodulator_priv;
>  	struct i2c_client *client = priv->client[0];
>  	int ret;
> -	struct reg_val_mask tab[] = {
> +	static const struct reg_val_mask tab[] = {
>  		{ 0x000ff, 0x1f, 0xff },
>  		{ 0x00085, 0x00, 0xff },
>  		{ 0x00088, 0x01, 0xff },
>