linux-kernel - Re: [PATCH v2] drm/amdgpu: Remove two redundant null pointer checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bd65192e-baca-19d7-47ec-dd5d0523ad30@amd.com>
Date:   Thu, 5 Sep 2019 05:55:28 +0000
From:   "Zhou, David(ChunMing)" <David1.Zhou@....com>
To:     zhong jiang <zhongjiang@...wei.com>,
        "airlied@...ux.ie" <airlied@...ux.ie>,
        "daniel@...ll.ch" <daniel@...ll.ch>
CC:     "Markus.Elfring@....de" <Markus.Elfring@....de>,
        "Deucher, Alexander" <Alexander.Deucher@....com>,
        "Koenig, Christian" <Christian.Koenig@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] drm/amdgpu: Remove two redundant null pointer checks


On 2019/9/5 下午1:49, zhong jiang wrote:
> The functions "debugfs_remove" and "kfree" tolerate the passing
> of null pointers. Hence it is unnecessary to check such arguments
> around the calls. Thus remove the extra condition check at two places.
>
> Signed-off-by: zhong jiang <zhongjiang@...wei.com>

Reviewed-by: Chunming Zhou <david1.zhou@....com>


> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
> index 5652cc7..cb94627 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
> @@ -1077,8 +1077,7 @@ static int amdgpu_debugfs_ib_preempt(void *data, u64 val)
>   
>   	ttm_bo_unlock_delayed_workqueue(&adev->mman.bdev, resched);
>   
> -	if (fences)
> -		kfree(fences);
> +	kfree(fences);
>   
>   	return 0;
>   }
> @@ -1103,8 +1102,7 @@ int amdgpu_debugfs_init(struct amdgpu_device *adev)
>   
>   void amdgpu_debugfs_preempt_cleanup(struct amdgpu_device *adev)
>   {
> -	if (adev->debugfs_preempt)
> -		debugfs_remove(adev->debugfs_preempt);
> +	debugfs_remove(adev->debugfs_preempt);
>   }
>   
>   #else