linux-kernel - Re: [PATCH -next] dmaengine: ti: edma: remove unused code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fb0b8690-e8c7-549c-b966-66d278dbe68a@ti.com>
Date:   Thu, 5 Sep 2019 11:02:33 +0300
From:   Peter Ujfalusi <peter.ujfalusi@...com>
To:     YueHaibing <yuehaibing@...wei.com>, <dan.j.williams@...el.com>,
        <vkoul@...nel.org>, <arnd@...db.de>
CC:     <dmaengine@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] dmaengine: ti: edma: remove unused code



On 05/09/2019 9.02, YueHaibing wrote:
> drivers/dma/ti/edma.c: In function edma_probe:
> drivers/dma/ti/edma.c:2252:11: warning:
>  variable off set but not used [-Wunused-but-set-variable]
> 
> 'off' is not used now, so remove it.

This reminds me that this whole in EDMA driver xbar handling is mostly
broken...

Acked-by: Peter Ujfalusi <peter.ujfalusi@...com>

> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/dma/ti/edma.c | 12 +-----------
>  1 file changed, 1 insertion(+), 11 deletions(-)
> 
> diff --git a/drivers/dma/ti/edma.c b/drivers/dma/ti/edma.c
> index ba7c4f0..54fd981 100644
> --- a/drivers/dma/ti/edma.c
> +++ b/drivers/dma/ti/edma.c
> @@ -2249,10 +2249,8 @@ static int edma_probe(struct platform_device *pdev)
>  {
>  	struct edma_soc_info	*info = pdev->dev.platform_data;
>  	s8			(*queue_priority_mapping)[2];
> -	int			i, off;
>  	const s16		(*rsv_slots)[2];
> -	const s16		(*xbar_chans)[2];
> -	int			irq;
> +	int			i, irq;
>  	char			*irq_name;
>  	struct resource		*mem;
>  	struct device_node	*node = pdev->dev.of_node;
> @@ -2349,14 +2347,6 @@ static int edma_probe(struct platform_device *pdev)
>  			edma_write_slot(ecc, i, &dummy_paramset);
>  	}
>  
> -	/* Clear the xbar mapped channels in unused list */
> -	xbar_chans = info->xbar_chans;
> -	if (xbar_chans) {
> -		for (i = 0; xbar_chans[i][1] != -1; i++) {
> -			off = xbar_chans[i][1];

originally we had
			clear_bits(off, 1, ecc->channel_unused);
here, but I have removed it for some reason with
1be5336bc7ba050ee07d352643bf4c01c513553c


> -		}
> -	}
> -
>  	irq = platform_get_irq_byname(pdev, "edma3_ccint");
>  	if (irq < 0 && node)
>  		irq = irq_of_parse_and_map(node, 0);
> 

- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki