linux-kernel - Re: [PATCH net] ipv4: fix ifa_flags reuse problem in using ifconfig tool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190905.121329.764571693233274743.davem@davemloft.net>
Date:   Thu, 05 Sep 2019 12:13:29 +0200 (CEST)
From:   David Miller <davem@...emloft.net>
To:     suyj.fnst@...fujitsu.com
Cc:     kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] ipv4: fix ifa_flags reuse problem in using
 ifconfig tool

From: Su Yanjun <suyj.fnst@...fujitsu.com>
Date: Wed, 4 Sep 2019 15:37:47 +0800

> When NetworkManager has already set ipv4 address then uses
> ifconfig set another ipv4 address. It will use previous ifa_flags
> that will cause device route not be inserted.
> 
> As NetworkManager has already support IFA_F_NOPREFIXROUTE flag [1],
> but ifconfig will reuse the ifa_flags. It's weird especially
> some old scripts or program [2]  still  use ifconfig.
> 
> [1] https://gitlab.freedesktop.org/NetworkManager/NetworkManager/
> commit/fec80e7473ad16979af75ed299d68103e7aa3fe9
> 
> [2] LTP or TAHI
> 
> Signed-off-by: Su Yanjun <suyj.fnst@...fujitsu.com>

I don't know about this.

This will lose things like IFA_F_SECONDARY as well.

Sorry, I am not convinced that this change is correct nor safe.