linux-kernel - Re: [PATCH -next 12/15] thermal: tango: use devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 05 Sep 2019 12:06:54 +0100
From:   Måns Rullgård <mans@...sr.com>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     <miquel.raynal@...tlin.com>, <rui.zhang@...el.com>,
        <edubezval@...il.com>, <daniel.lezcano@...aro.org>,
        <amit.kucheria@...durent.com>, <eric@...olt.net>,
        <wahrenst@....net>, <f.fainelli@...il.com>, <rjui@...adcom.com>,
        <sbranden@...adcom.com>, <mmayer@...adcom.com>,
        <computersforpeace@...il.com>, <gregory.0xf0@...il.com>,
        <matthias.bgg@...il.com>, <agross@...nel.org>, <heiko@...ech.de>,
        <mcoquelin.stm32@...il.com>, <alexandre.torgue@...com>,
        <marc.w.gonzalez@...e.fr>, <talel@...zon.com>,
        <jun.nie@...aro.org>, <shawnguo@...nel.org>,
        <phil@...pberrypi.org>, <gregkh@...uxfoundation.org>,
        <david.hernandezsanchez@...com>, <horms+renesas@...ge.net.au>,
        <wsa+renesas@...g-engineering.com>,
        <bcm-kernel-feedback-list@...adcom.com>,
        <linux-pm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-rpi-kernel@...ts.infradead.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-mediatek@...ts.infradead.org>,
        <linux-arm-msm@...r.kernel.org>,
        <linux-rockchip@...ts.infradead.org>,
        <linux-stm32@...md-mailman.stormreply.com>
Subject: Re: [PATCH -next 12/15] thermal: tango: use devm_platform_ioremap_resource() to simplify code

YueHaibing <yuehaibing@...wei.com> writes:

> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
>
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Acked-by: Mans Rullgard <mans@...sr.com>

> ---
>  drivers/thermal/tango_thermal.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/thermal/tango_thermal.c b/drivers/thermal/tango_thermal.c
> index 304b461..f44441b 100644
> --- a/drivers/thermal/tango_thermal.c
> +++ b/drivers/thermal/tango_thermal.c
> @@ -73,7 +73,6 @@ static void tango_thermal_init(struct tango_thermal_priv *priv)
>
>  static int tango_thermal_probe(struct platform_device *pdev)
>  {
> -	struct resource *res;
>  	struct tango_thermal_priv *priv;
>  	struct thermal_zone_device *tzdev;
>
> @@ -81,8 +80,7 @@ static int tango_thermal_probe(struct platform_device *pdev)
>  	if (!priv)
>  		return -ENOMEM;
>
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	priv->base = devm_ioremap_resource(&pdev->dev, res);
> +	priv->base = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(priv->base))
>  		return PTR_ERR(priv->base);
>
> -- 
> 2.7.4
>

-- 
Måns Rullgård