linux-kernel - Re: [PATCH 1/2] i2c: qcom-geni: Provide an option to select FIFO processing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190905133743.GE1157@kunai>
Date:   Thu, 5 Sep 2019 15:37:43 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Bjorn Andersson <bjorn.andersson@...aro.org>, alokc@...eaurora.org,
        agross@...nel.org, robh+dt@...nel.org, mark.rutland@....com,
        linux-i2c@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] i2c: qcom-geni: Provide an option to select FIFO
 processing


> > So, are there investigations running why this reboot happens?
> 
> Yes, but they have been running for months, literally.

I see. This is good to know. Just so I also know where we are with this.

> > Which is a clear disadvantage of that solution. It won't fix older
> > kernels. My suggestion above should fix them, too.
> 
> Not sure how this is possible.  Unless you mean LTS?

Why not? Using of_machine_is_compatible() makes the patch 100% self
contained (no extra binding needed). It will work wherever the machine
description fits.

> > Unless we know why the reboot happens on your platform, I'd be careful
> > with saying "work obviously well" on other platforms.
> 
> Someone must have tested it?  Surely ... ;)

It seems to work mostly, I won't deny that. But we don't know if the
buggy situation can be triggered on these platforms as well by something
else later. We just don't know.

> > My suggestion:
> > 
> > For 5.3, use of_machine_is_compatible() and we backport that. For later,
> > try to find out the root cause and fix it. If that can't be done, try to
> > set up a generic "disable-dma" property and use it.
> > 
> > What do you think about that?
> 
> Sounds okay to me.  Let me code that up.

Glad you like it.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)