linux-kernel - Re: [PATCH] drm/msm/dsi: Move static keyword to the front of declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 5 Sep 2019 08:26:39 -0600
From:   Jeffrey Hugo <jeffrey.l.hugo@...il.com>
To:     Krzysztof Wilczynski <kw@...ux.com>
Cc:     Rob Clark <robdclark@...il.com>, Sean Paul <sean@...rly.run>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Alexios Zavras <alexios.zavras@...el.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Allison Randal <allison@...utok.net>,
        MSM <linux-arm-msm@...r.kernel.org>,
        "open list:DRM PANEL DRIVERS" <dri-devel@...ts.freedesktop.org>,
        freedreno <freedreno@...ts.freedesktop.org>,
        lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/msm/dsi: Move static keyword to the front of declarations

On Wed, Sep 4, 2019 at 3:15 PM Krzysztof Wilczynski <kw@...ux.com> wrote:
>
> Move the static keyword to the front of declarations
> of msm_dsi_v2_host_ops, msm_dsi_6g_host_ops and
> msm_dsi_6g_v2_host_ops, and resolve the following
> compiler warnings that can be seen when building
> with warnings enabled (W=1):
>
> drivers/gpu/drm/msm/dsi/dsi_cfg.c:150:1: warning:
>   ‘static’ is not at beginning of declaration [-Wold-style-declaration]
>
> drivers/gpu/drm/msm/dsi/dsi_cfg.c:161:1: warning:
>   ‘static’ is not at beginning of declaration [-Wold-style-declaration]
>
> drivers/gpu/drm/msm/dsi/dsi_cfg.c:172:1: warning:
>   ‘static’ is not at beginning of declaration [-Wold-style-declaration]
>
> Signed-off-by: Krzysztof Wilczynski <kw@...ux.com>

Seems fine to me.

Reviewed-by: Jeffrey Hugo <jeffrey.l.hugo@...il.com>