linux-kernel - Re: [PATCH v2 05/35] clk/ti: Use kmemdup rather than duplicating its implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190906212033.E6D002070C@mail.kernel.org>
Date:   Fri, 06 Sep 2019 14:20:33 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Fuqian Huang <huangfq.daxian@...il.com>
Cc:     Tero Kristo <t-kristo@...com>,
        Michael Turquette <mturquette@...libre.com>,
        linux-omap@...r.kernel.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Fuqian Huang <huangfq.daxian@...il.com>
Subject: Re: [PATCH v2 05/35] clk/ti: Use kmemdup rather than duplicating its implementation

Quoting Fuqian Huang (2019-07-03 09:27:00)
> kmemdup is introduced to duplicate a region of memory in a neat way.
> Rather than kmalloc/kzalloc + memcpy, which the programmer needs to
> write the size twice (sometimes lead to mistakes), kmemdup improves
> readability, leads to smaller code and also reduce the chances of mistakes.
> Suggestion to use kmemdup rather than using kmalloc/kzalloc + memcpy.
> 
> Signed-off-by: Fuqian Huang <huangfq.daxian@...il.com>
> ---

Applied to clk-next