linux-kernel - Re: [PATCH -next] coccinelle: platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d71eb6f.1c69fb81.31bc8.da2d@mx.google.com>
Date:   Thu, 05 Sep 2019 22:15:26 -0700
From:   Stephen Boyd <swboyd@...omium.org>
To:     Gilles.Muller@...6.fr, Julia.Lawall@...6.fr,
        gregkh@...uxfoundation.org, michal.lkml@...kovi.net,
        nicolas.palix@...g.fr, yuehaibing@...wei.com
Cc:     cocci@...teme.lip6.fr, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] coccinelle: platform_get_irq: Fix parse error

Quoting YueHaibing (2019-09-05 20:30:06)
> When do coccicheck, I get this error:
> 
> spatch -D report --no-show-diff --very-quiet --cocci-file
> ./scripts/coccinelle/api/platform_get_irq.cocci --include-headers
> --dir . -I ./arch/x86/include -I ./arch/x86/include/generated -I ./include
>  -I ./arch/x86/include/uapi -I ./arch/x86/include/generated/uapi
>  -I ./include/uapi -I ./include/generated/uapi
>  --include ./include/linux/kconfig.h --jobs 192 --chunksize 1
> minus: parse error:
>   File "./scripts/coccinelle/api/platform_get_irq.cocci", line 24, column 9, charpos = 355
>   around = '\(',
>   whole content = if ( ret \( < \| <= \) 0 )
> 
> In commit e56476897448 ("fpga: Remove dev_err() usage
> after platform_get_irq()") log, I found the semantic patch,
> it fix this issue.
> 
> Fixes: 98051ba2b28b ("coccinelle: Add script to check for platform_get_irq() excessive prints")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---

Hmm I had this earlier but someone asked me to change it.

Reviewed-by: Stephen Boyd <swboyd@...omium.org>