linux-kernel - [tip: x86/platform] x86/platform/uv: Fix kmalloc() NULL check routine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <156774853124.13152.5026817368988742001.tip-bot2@tip-bot2>
Date:   Fri, 06 Sep 2019 05:42:11 -0000
From:   "tip-bot2 for Austin Kim" <tip-bot2@...utronix.de>
To:     linux-tip-commits@...r.kernel.org
Cc:     Ingo Molnar <mingo@...nel.org>, Borislav Petkov <bp@...en8.de>,
        linux-kernel@...r.kernel.org
Subject: [tip: x86/platform] x86/platform/uv: Fix kmalloc() NULL check routine

The following commit has been merged into the x86/platform branch of tip:

Commit-ID:     864b23f0169d5bff677e8443a7a90dfd6b090afc
Gitweb:        https://git.kernel.org/tip/864b23f0169d5bff677e8443a7a90dfd6b090afc
Author:        Austin Kim <austindh.kim@...il.com>
AuthorDate:    Fri, 06 Sep 2019 08:29:51 +09:00
Committer:     Ingo Molnar <mingo@...nel.org>
CommitterDate: Fri, 06 Sep 2019 07:36:16 +02:00

x86/platform/uv: Fix kmalloc() NULL check routine

The result of kmalloc() should have been checked ahead of below statement:

	pqp = (struct bau_pq_entry *)vp;

Move BUG_ON(!vp) before above statement.

Signed-off-by: Austin Kim <austindh.kim@...il.com>
Cc: Dimitri Sivanich <dimitri.sivanich@....com>
Cc: Hedi Berriche <hedi.berriche@....com>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Mike Travis <mike.travis@....com>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Russ Anderson <russ.anderson@....com>
Cc: Steve Wahl <steve.wahl@....com>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: allison@...utok.net
Cc: andy@...radead.org
Cc: armijn@...ldur.nl
Cc: bp@...en8.de
Cc: dvhart@...radead.org
Cc: gregkh@...uxfoundation.org
Cc: hpa@...or.com
Cc: kjlu@....edu
Cc: platform-driver-x86@...r.kernel.org
Link: https://lkml.kernel.org/r/20190905232951.GA28779@LGEARND20B15
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 arch/x86/platform/uv/tlb_uv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/platform/uv/tlb_uv.c b/arch/x86/platform/uv/tlb_uv.c
index 20c389a..5f0a96b 100644
--- a/arch/x86/platform/uv/tlb_uv.c
+++ b/arch/x86/platform/uv/tlb_uv.c
@@ -1804,9 +1804,9 @@ static void pq_init(int node, int pnode)
 
 	plsize = (DEST_Q_SIZE + 1) * sizeof(struct bau_pq_entry);
 	vp = kmalloc_node(plsize, GFP_KERNEL, node);
-	pqp = (struct bau_pq_entry *)vp;
-	BUG_ON(!pqp);
+	BUG_ON(!vp);
 
+	pqp = (struct bau_pq_entry *)vp;
 	cp = (char *)pqp + 31;
 	pqp = (struct bau_pq_entry *)(((unsigned long)cp >> 5) << 5);