linux-kernel - Re: [PATCH v13 7/8] ARM: dts: exynos: add DMC device for exynos5422

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 6 Sep 2019 10:41:02 +0200
From:   Lukasz Luba <l.luba@...tner.samsung.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-pm@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
        linux-clk@...r.kernel.org, mturquette@...libre.com,
        sboyd@...nel.org, b.zolnierkie@...sung.com, kgene@...nel.org,
        mark.rutland@....com, robh+dt@...nel.org, cw00.choi@...sung.com,
        kyungmin.park@...sung.com, m.szyprowski@...sung.com,
        s.nawrocki@...sung.com, myungjoo.ham@...sung.com,
        keescook@...omium.org, tony@...mide.com, jroedel@...e.de,
        treding@...dia.com, digetx@...il.com, gregkh@...uxfoundation.org,
        willy.mh.wolff.ml@...il.com
Subject: Re: [PATCH v13 7/8] ARM: dts: exynos: add DMC device for exynos5422

Hi Krzysztof,

On 9/4/19 8:25 PM, Krzysztof Kozlowski wrote:
> On Wed, Aug 21, 2019 at 12:43:02PM +0200, Lukasz Luba wrote:
>> Add description of Dynamic Memory Controller and PPMU counters.
>> They are used by exynos5422-dmc driver.
>> There is a definition of the memory chip, which is then used during
>> calculation of timings for each OPP.
>> The algorithm in the driver needs these two sets to bound the timings.
>>
>> Signed-off-by: Lukasz Luba <l.luba@...tner.samsung.com>
>> ---
>>   arch/arm/boot/dts/exynos5420.dtsi             |  71 +++++++++++
>>   arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 116 ++++++++++++++++++
>>   2 files changed, 187 insertions(+)
> 
> Thanks, applied conditionally. Please send a follow up fixing the
> checkpatch error about undocumented binding:
> https://krzk.eu/#/builders/26/builds/392
> 
> You should not skip such checkpatch warning.
Right, I will keep it in mind next time. I have just ignore it based on
Elpida lpddr2 memory which is also missing DT binding documentation.
https://elixir.bootlin.com/linux/v5.3-rc7/source/arch/arm/boot/dts/elpida_ecb240abacn.dtsi

I will send a follow up patch based on your 'for-next' branch.

Regards,
Lukasz
> 
> Best regards,
> Krzysztof
> 
> 
>