linux-kernel - Re: [RESEND][PATCH v2 0/2] Fix misuse of blk_rq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 6 Sep 2019 18:00:02 +0300
From:   Pavel Begunkov <asml.silence@...il.com>
To:     Jens Axboe <axboe@...nel.dk>, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, josef@...icpanda.com
Subject: Re: [RESEND][PATCH v2 0/2] Fix misuse of blk_rq_stats in
 blk-iolatency

Jens, could you please at last take a look?

The patches have been stalling here for almost 2 months
(see
https://lkml.kernel.org/lkml/ac0700a1-0984-417b-d5d8-35c4ba56f6f6@gmail.com/T/)

Thanks

On 06/09/2019 17:42, Pavel Begunkov (Silence) wrote:
> From: Pavel Begunkov <asml.silence@...il.com>
> 
> There are implicit assumptions about struct blk_rq_stats, which make
> it's very easy to misuse. The first patch fixes a bug caused by that.
> The second employs type-system to prevent recurrences.
> 
> v2: rebase + reformulate commit messages (no code changes)
> 
> Acked-by: Josef Bacik <josef@...icpanda.com>
> 
> Pavel Begunkov (2):
>   blk-iolatency: Fix zero mean in previous stats
>   blk-stats: Introduce explicit stat staging buffers
> 
>  block/blk-iolatency.c     | 60 ++++++++++++++++++++++++++++++---------
>  block/blk-stat.c          | 48 +++++++++++++++++++++++--------
>  block/blk-stat.h          |  9 ++++--
>  include/linux/blk_types.h |  6 ++++
>  4 files changed, 94 insertions(+), 29 deletions(-)
> 

-- 
Yours sincerely,
Pavel Begunkov



Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)