linux-kernel - RE: [PATCH] kunit: add PRINTK dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ECADFF3FD767C149AD96A924E7EA6EAF977A9B7B@USCULXMSG01.am.sony.com>
Date:   Fri, 6 Sep 2019 15:31:02 +0000
From:   <Tim.Bird@...y.com>
To:     <arnd@...db.de>, <brendanhiggins@...gle.com>
CC:     <gregkh@...uxfoundation.org>, <logang@...tatee.com>,
        <sboyd@...nel.org>, <skhan@...uxfoundation.org>,
        <linux-kselftest@...r.kernel.org>, <kunit-dev@...glegroups.com>,
        <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] kunit: add PRINTK dependency

Minor spelling nit..

> -----Original Message-----
> From: Arnd Bergmann
> 
> The vprintk_emit() function is not available when CONFIG_PRINTK
> is disabled:
> 
> kunit/test.c:22:9: error: implicit declaration of function 'vprintk_emit' [-
> Werror,-Wimplicit-function-declaration]
> 
> I suppose without printk(), there is not much use in kunit
> either, so add a Kconfig depenedency here.
depenedency -> dependency

> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  kunit/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kunit/Kconfig b/kunit/Kconfig
> index 8541ef95b65a..e80d8af00454 100644
> --- a/kunit/Kconfig
> +++ b/kunit/Kconfig
> @@ -6,6 +6,7 @@ menu "KUnit support"
> 
>  config KUNIT
>  	bool "Enable support for unit tests (KUnit)"
> +	depends on PRINTK
>  	help
>  	  Enables support for kernel unit tests (KUnit), a lightweight unit
>  	  testing and mocking framework for the Linux kernel. These tests are
> --
> 2.20.0