linux-kernel - Re: [PATCH] staging: rtl8188eu: make two arrays static const, makes object smaller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9f1e1550-2a75-abc3-4d87-a0c1d1ae1ccb@lwfinger.net>
Date:   Fri, 6 Sep 2019 12:50:39 -0500
From:   Larry Finger <Larry.Finger@...inger.net>
To:     Colin King <colin.king@...onical.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8188eu: make two arrays static const, makes
 object smaller

On 9/6/19 12:39 PM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Don't populate two arrays on the stack but instead make them
> static const. Makes the object code smaller by 49 bytes.
> 
> Before:
>     text	   data	    bss	    dec	    hex	filename
>    26821	   5616	      0	  32437	   7eb5	rtl8188eu/core/rtw_ieee80211.o
> 
> After:
>     text	   data	    bss	    dec	    hex	filename
>    26612	   5776	      0	  32388	   7e84	rtl8188eu/core/rtw_ieee80211.o
> 
> (gcc version 9.2.1, amd64)
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---

Acked-by: Larry Finger <Larry.Finger@...inger.net>

Thanks,

Larry