linux-kernel - Re: [PATCH] [RFC] Revert "iio: hid-sensor-attributes: Convert to use int

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a1S2g__qn4LP+z=ah4L2AJCHndn3LWbMkPedsu_HOd1_g@mail.gmail.com>
Date:   Fri, 6 Sep 2019 20:46:00 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Alexios Zavras <alexios.zavras@...el.com>,
        Colin Ian King <colin.king@...onical.com>,
        linux-iio@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] [RFC] Revert "iio: hid-sensor-attributes: Convert to use int_pow()"

On Fri, Sep 6, 2019 at 6:55 PM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
>
> On Fri, Sep 06, 2019 at 05:45:55PM +0200, Arnd Bergmann wrote:
> > The change to use the generic int_pow instead of the private version
> > caused a number of build issues on 32-bit architectures and makes
> > it generally less efficient because of the 64-bit math:
> >
> > drivers/iio/common/hid-sensors/hid-sensor-attributes.o: In function `hid_sensor_write_samp_freq_value':
> > hid-sensor-attributes.c:(.text+0x29c): undefined reference to `__aeabi_uldivmod'
> > drivers/iio/common/hid-sensors/hid-sensor-attributes.o: In function `hid_sensor_read_raw_hyst_value':
> > hid-sensor-attributes.c:(.text+0x420): undefined reference to `__aeabi_uldivmod'
> > hid-sensor-attributes.c:(.text+0x448): undefined reference to `__aeabi_uldivmod'
> > drivers/iio/common/hid-sensors/hid-sensor-attributes.o: In function `hid_sensor_write_raw_hyst_value':
> > hid-sensor-attributes.c:(.text+0x570): undefined reference to `__aeabi_uldivmod'
> >
> > There is probably a nicer solution to this, but for the moment,
> > the revert makes it compile again.
> >
> > Fixes: 473d12f7638c ("iio: hid-sensor-attributes: Convert to use int_pow()")
>
> Does the fix [1] works for you?
>
> [1]: https://lore.kernel.org/linux-iio/6851830d050ddb2f27d1e6969755ee4f3293d37c.camel@intel.com/

It looks like a better fix, I applied that on my test build tree now, will
let you know if I find any remaining unexpected problems with it.

       Arnd