linux-kernel - Re: [PATCH] samples: watch_queue: add HEADERS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a2GRZJQThJAdavv_EKp27dtUtysKtpYpkKSSupTJ4qemg@mail.gmail.com>
Date:   Sat, 7 Sep 2019 14:53:16 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     David Howells <dhowells@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Christian Brauner <christian@...uner.io>,
        Mauro Carvalho Chehab <mchehab+samsung@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] samples: watch_queue: add HEADERS_INSTALL dependency

On Sat, Sep 7, 2019 at 4:07 AM Masahiro Yamada
<yamada.masahiro@...ionext.com> wrote:
>
> samples/watch_queue/Makefile specifies the header search path
> -I$(objtree)/usr/include, which is probaby needed to include
> <linux/watch_queue.h> etc.
>
> To make it work properly, add "depends on HEADERS_INSTALL" so that
> headers are installed into $(objtree)/usr/include before building
> this sample.
>
> Fixes: 7141642ed120 ("Add sample notification program")
> Reported-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>

Tested-by: Arnd Bergmann <arnd@...db.de>

> Arnd reported a build error:
> https://lkml.org/lkml/2019/9/6/665
>
> Missing "depends on HEADERS_INSTALL" is the only reason
> I have in my mind.
>
> If it still fails to build, I do not know why.

It works, thanks for the fix!

       Arnd