linux-kernel - drivers/crypto/talitos.c:3142:4: warning: this statement may fall through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <201909080015.Hjs2tfjw%lkp@intel.com>
Date:   Sun, 8 Sep 2019 00:16:28 +0800
From:   kbuild test robot <lkp@...el.com>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     kbuild-all@...org, linux-kernel@...r.kernel.org
Subject: drivers/crypto/talitos.c:3142:4: warning: this statement may fall
 through

tree:   https://kernel.googlesource.com/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   1e3778cb223e861808ae0daccf353536e7573eed
commit: a035d552a93bb9ef6048733bb9f2a0dc857ff869 Makefile: Globally enable fall-through warning
date:   6 weeks ago
config: powerpc-mpc83xx_defconfig (attached as .config)
compiler: powerpc-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout a035d552a93bb9ef6048733bb9f2a0dc857ff869
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/crypto/talitos.c: In function 'talitos_remove':
>> drivers/crypto/talitos.c:3142:4: warning: this statement may fall through [-Wimplicit-fallthrough=]
       crypto_unregister_aead(&t_alg->algt.alg.aead);
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/crypto/talitos.c:3143:3: note: here
      case CRYPTO_ALG_TYPE_AHASH:
      ^~~~

vim +3142 drivers/crypto/talitos.c

9c4a79653b35ef Kim Phillips 2008-06-23  3129  
2dc11581376829 Grant Likely 2010-08-06  3130  static int talitos_remove(struct platform_device *ofdev)
9c4a79653b35ef Kim Phillips 2008-06-23  3131  {
9c4a79653b35ef Kim Phillips 2008-06-23  3132  	struct device *dev = &ofdev->dev;
9c4a79653b35ef Kim Phillips 2008-06-23  3133  	struct talitos_private *priv = dev_get_drvdata(dev);
9c4a79653b35ef Kim Phillips 2008-06-23  3134  	struct talitos_crypto_alg *t_alg, *n;
9c4a79653b35ef Kim Phillips 2008-06-23  3135  	int i;
9c4a79653b35ef Kim Phillips 2008-06-23  3136  
9c4a79653b35ef Kim Phillips 2008-06-23  3137  	list_for_each_entry_safe(t_alg, n, &priv->alg_list, entry) {
acbf7c627fb59d Lee Nipper   2010-05-19  3138  		switch (t_alg->algt.type) {
acbf7c627fb59d Lee Nipper   2010-05-19  3139  		case CRYPTO_ALG_TYPE_ABLKCIPHER:
acbf7c627fb59d Lee Nipper   2010-05-19  3140  			break;
aeb4c132f33d21 Herbert Xu   2015-07-30  3141  		case CRYPTO_ALG_TYPE_AEAD:
aeb4c132f33d21 Herbert Xu   2015-07-30 @3142  			crypto_unregister_aead(&t_alg->algt.alg.aead);
acbf7c627fb59d Lee Nipper   2010-05-19  3143  		case CRYPTO_ALG_TYPE_AHASH:
acbf7c627fb59d Lee Nipper   2010-05-19  3144  			crypto_unregister_ahash(&t_alg->algt.alg.hash);
acbf7c627fb59d Lee Nipper   2010-05-19  3145  			break;
acbf7c627fb59d Lee Nipper   2010-05-19  3146  		}
9c4a79653b35ef Kim Phillips 2008-06-23  3147  		list_del(&t_alg->entry);
9c4a79653b35ef Kim Phillips 2008-06-23  3148  	}
9c4a79653b35ef Kim Phillips 2008-06-23  3149  
9c4a79653b35ef Kim Phillips 2008-06-23  3150  	if (hw_supports(dev, DESC_HDR_SEL0_RNG))
9c4a79653b35ef Kim Phillips 2008-06-23  3151  		talitos_unregister_rng(dev);
9c4a79653b35ef Kim Phillips 2008-06-23  3152  
c3e337f88a5b37 Kim Phillips 2011-11-21  3153  	for (i = 0; i < 2; i++)
2cdba3cf6ffc1f Kim Phillips 2011-12-12  3154  		if (priv->irq[i]) {
c3e337f88a5b37 Kim Phillips 2011-11-21  3155  			free_irq(priv->irq[i], dev);
c3e337f88a5b37 Kim Phillips 2011-11-21  3156  			irq_dispose_mapping(priv->irq[i]);
9c4a79653b35ef Kim Phillips 2008-06-23  3157  		}
9c4a79653b35ef Kim Phillips 2008-06-23  3158  
c3e337f88a5b37 Kim Phillips 2011-11-21  3159  	tasklet_kill(&priv->done_task[0]);
2cdba3cf6ffc1f Kim Phillips 2011-12-12  3160  	if (priv->irq[1])
c3e337f88a5b37 Kim Phillips 2011-11-21  3161  		tasklet_kill(&priv->done_task[1]);
9c4a79653b35ef Kim Phillips 2008-06-23  3162  
9c4a79653b35ef Kim Phillips 2008-06-23  3163  	return 0;
9c4a79653b35ef Kim Phillips 2008-06-23  3164  }
9c4a79653b35ef Kim Phillips 2008-06-23  3165  

:::::: The code at line 3142 was first introduced by commit
:::::: aeb4c132f33d21f6cf37558a932e66e40dd8982e crypto: talitos - Convert to new AEAD interface

:::::: TO: Herbert Xu <herbert@...dor.apana.org.au>
:::::: CC: Herbert Xu <herbert@...dor.apana.org.au>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (18557 bytes)