linux-kernel - Re: [PATCH v5] tpm: Parse event log from TPM2 ACPI table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0dfdac6faab2ebeb3bbffd1ce66b26f26dab03f5.camel@linux.intel.com>
Date:   Sat, 07 Sep 2019 20:28:13 +0300
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     Jordan Hand <jorhand@...ux.microsoft.com>
Cc:     Peter Huewe <peterhuewe@....de>, Jason Gunthorpe <jgg@...pe.ca>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Allison Randal <allison@...utok.net>,
        linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5] tpm: Parse event log from TPM2 ACPI table

On Tue, 2019-09-03 at 11:52 -0700, Jordan Hand wrote:
> For systems with a TPM2 chip which use ACPI to expose event logs,
> retrieve the crypto-agile event log from the TPM2 ACPI table. The TPM2
> table is defined in section 7.3 of the TCG ACPI Specification (see link).
> 
> The TPM2 table is used by SeaBIOS in place of the TCPA table when the
> system's TPM is version 2.0 to denote (among other metadata) the location
> of the crypto-agile log.
> 
> Link: https://trustedcomputinggroup.org/resource/tcg-acpi-specification/
> Signed-off-by: Jordan Hand <jorhand@...ux.microsoft.com>

You should rather rename the existing function as
tpm_read_log_acpi_tcpa() and create a new one with the name
tpm_read_log_acpi_tpm2().

/Jarkko