linux-kernel - Re: [PATCH] z3fold: fix retry mechanism in page reclaim

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1ed46a95-12bc-d8ee-0770-43057a09f0d9@maciej.szmigiero.name>
Date:   Sun, 8 Sep 2019 15:56:45 +0200
From:   "Maciej S. Szmigiero" <mail@...iej.szmigiero.name>
To:     Vitaly Wool <vitalywool@...il.com>
Cc:     Linux-MM <linux-mm@...ck.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org,
        Agustín DallʼAlba <agustin@...lalba.com.ar>,
        Dan Streetman <ddstreet@...e.org>,
        Vlastimil Babka <vbabka@...e.cz>, markus.linnala@...il.com
Subject: Re: [PATCH] z3fold: fix retry mechanism in page reclaim

On 08.09.2019 15:29, Vitaly Wool wrote:
> z3fold_page_reclaim()'s retry mechanism is broken: on a second
> iteration it will have zhdr from the first one so that zhdr
> is no longer in line with struct page. That leads to crashes when
> the system is stressed.
> 
> Fix that by moving zhdr assignment up.
> 
> While at it, protect against using already freed handles by using
> own local slots structure in z3fold_page_reclaim().
> 
> Reported-by: Markus Linnala <markus.linnala@...il.com>
> Reported-by: Chris Murphy <bugzilla@...orremedies.com>
> Reported-by: Agustin Dall'Alba <agustin@...lalba.com.ar>
> Signed-off-by: Vitaly Wool <vitalywool@...il.com>
> ---

Shouldn't this be CC'ed to stable@ ?

Maciej