linux-kernel - Re: [PATCH v2 1/3] staging: exfat: drop duplicate date_time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190908164552.GD8362@kroah.com>
Date:   Sun, 8 Sep 2019 17:45:52 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Valentin Vidic <vvidic@...entin-vidic.from.hr>
Cc:     devel@...verdev.osuosl.org,
        Valdis Kletnieks <valdis.kletnieks@...edu>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/3] staging: exfat: drop duplicate date_time_t struct

On Sun, Sep 08, 2019 at 04:10:13PM +0000, Valentin Vidic wrote:
> Use timestamp_t for everything and cleanup duplicate code.

You dropped function parameters in here, which you did not describe in
this changelog text :(

Please only try to do "one logical thing" per patch to make it easier to
review and revert if something goes wrong :)

thanks,

greg k-h