lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 8 Sep 2019 10:16:02 +0200 From: Borislav Petkov <bp@...en8.de> To: "Hawa, Hanna" <hhhawa@...zon.com> Cc: Robert Richter <rrichter@...vell.com>, "mchehab@...nel.org" <mchehab@...nel.org>, "james.morse@....com" <james.morse@....com>, "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "dwmw@...zon.co.uk" <dwmw@...zon.co.uk>, "benh@...zon.com" <benh@...zon.com>, "ronenk@...zon.com" <ronenk@...zon.com>, "talel@...zon.com" <talel@...zon.com>, "jonnyc@...zon.com" <jonnyc@...zon.com>, "hanochu@...zon.com" <hanochu@...zon.com> Subject: Re: [PATCH 1/1] edac: Add an API for edac device to report for multiple errors On Sun, Sep 08, 2019 at 10:58:31AM +0300, Hawa, Hanna wrote: > > Better use WARN_ON_ONCE() to avoid flooding. > > In case of two drivers using this function with wrong error count, only the > first WARN_ON_ONCE will catch in this case, and other will miss other wrong > usage of other edac device drivers. The idea is to catch any driver using a 0 error count and fix it, not to flood dmesg. You want _ONCE. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette
Powered by blists - more mailing lists