linux-kernel - Re: [PATCH -next] perf/smmuv3: gpio: creg-snps: use devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <de66c0f1-129e-846d-1bde-f2e45b38dd82@huawei.com>
Date:   Mon, 9 Sep 2019 09:25:11 +0800
From:   Yuehaibing <yuehaibing@...wei.com>
To:     <will@...nel.org>, <mark.rutland@....com>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] perf/smmuv3: gpio: creg-snps: use
 devm_platform_ioremap_resource() to simplify code

The patch title is wrong,  fix it in v2, sorry.

On 2019/9/6 22:38, YueHaibing wrote:
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/perf/arm_smmuv3_pmu.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/perf/arm_smmuv3_pmu.c b/drivers/perf/arm_smmuv3_pmu.c
> index abcf54f..773128f 100644
> --- a/drivers/perf/arm_smmuv3_pmu.c
> +++ b/drivers/perf/arm_smmuv3_pmu.c
> @@ -727,7 +727,7 @@ static void smmu_pmu_get_acpi_options(struct smmu_pmu *smmu_pmu)
>  static int smmu_pmu_probe(struct platform_device *pdev)
>  {
>  	struct smmu_pmu *smmu_pmu;
> -	struct resource *res_0, *res_1;
> +	struct resource *res_0;
>  	u32 cfgr, reg_size;
>  	u64 ceid_64[2];
>  	int irq, err;
> @@ -764,8 +764,7 @@ static int smmu_pmu_probe(struct platform_device *pdev)
>  
>  	/* Determine if page 1 is present */
>  	if (cfgr & SMMU_PMCG_CFGR_RELOC_CTRS) {
> -		res_1 = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> -		smmu_pmu->reloc_base = devm_ioremap_resource(dev, res_1);
> +		smmu_pmu->reloc_base = devm_platform_ioremap_resource(pdev, 1);
>  		if (IS_ERR(smmu_pmu->reloc_base))
>  			return PTR_ERR(smmu_pmu->reloc_base);
>  	} else {
>