linux-kernel - Re: [PATCHv2] nvme: Assign subsy instance from first ctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 9 Sep 2019 12:32:43 +0200
From:   Hannes Reinecke <hare@...e.de>
To:     Keith Busch <kbusch@...nel.org>, Sagi Grimberg <sagi@...mberg.me>,
        linux-nvme@...ts.infradead.org, Christoph Hellwig <hch@....de>
Cc:     Logan Gunthorpe <logang@...tatee.com>, Jens Axboe <axboe@...com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        Hannes Reinecke <hare@...e.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCHv2] nvme: Assign subsy instance from first ctrl

On 9/5/19 6:33 PM, Keith Busch wrote:
> The namespace disk names must be unique for the lifetime of the
> subsystem. This was accomplished by using their parent subsystems'
> instances which were allocated independently from the controllers
> connected to that subsystem. This allowed name prefixes assigned to
> namespaces to match a controller from an unrelated subsystem, and has
> created confusion among users examining device nodes.
> 
> Ensure a namespace's subsystem instance never clashes with a controller
> instance of another subsystem by transferring the instance ownership
> to the parent subsystem from the first controller discovered in that
> subsystem.
> 
> Reviewed-by: Logan Gunthorpe <logang@...tatee.com>
> Signed-off-by: Keith Busch <kbusch@...nel.org>
> ---
> v1 -> v2:
> 
>   Changelog: reduce sensationalism, fix spelling 
> 
>  drivers/nvme/host/core.c | 21 ++++++++++-----------
>  1 file changed, 10 insertions(+), 11 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare@...e.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      Teamlead Storage & Networking
hare@...e.de			                  +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 247165 (AG München), GF: Felix Imendörffer