linux-kernel - Re: crypto: caam - Cast to long first before pointer conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 9 Sep 2019 11:06:55 +0000
From:   Horia Geanta <horia.geanta@....com>
To:     Herbert Xu <herbert@...dor.apana.org.au>,
        Andrey Smirnov <andrew.smirnov@...il.com>
CC:     "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        Chris Healy <cphealy@...il.com>,
        Lucas Stach <l.stach@...gutronix.de>,
        Iuliana Prodan <iuliana.prodan@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: crypto: caam - Cast to long first before pointer conversion

On 9/9/2019 10:46 AM, Herbert Xu wrote:
> On Tue, Sep 03, 2019 at 07:35:07PM -0700, Andrey Smirnov wrote:
>> With IRQ requesting being managed by devres we need to make sure that
>> we dispose of IRQ mapping after and not before it is free'd (otherwise
>> we'll end up with a warning from the kernel). To achieve that simply
>> convert IRQ mapping to rely on devres as well.
>>
>> Fixes: f314f12db65c ("crypto: caam - convert caam_jr_init() to use devres")
>> Signed-off-by: Andrey Smirnov <andrew.smirnov@...il.com>
>> Cc: Chris Healy <cphealy@...il.com>
>> Cc: Lucas Stach <l.stach@...gutronix.de>
>> Cc: Horia Geantă <horia.geanta@....com>
>> Cc: Herbert Xu <herbert@...dor.apana.org.au>
>> Cc: Iuliana Prodan <iuliana.prodan@....com>
>> Cc: linux-crypto@...r.kernel.org
>> Cc: linux-kernel@...r.kernel.org
>> ---
>>  drivers/crypto/caam/jr.c | 14 ++++++++++----
>>  1 file changed, 10 insertions(+), 4 deletions(-)
> 
> I needed to apply this on top of it to shut up the compiler:
> 
> ---8<---
> While storing an int in a pointer is safe the compiler is not
> happy about it.  So we need some extra casting in order to make
> this warning free.
> 
> Fixes: 1d3f75bce123 ("crypto: caam - dispose of IRQ mapping only...")
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>
> 
Thanks Herbert.

Indeed, this is needed for silencing compilation on ARM64
(while compiling for ARM works fine).

Reviewed-by: Horia Geantă <horia.geanta@....com>
for the squashed patches.

Horia