linux-kernel - Re: [PATCH] ssb: make array pwr_info_offset static const, makes object smaller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 9 Sep 2019 19:53:12 +0200
From:   Michael Büsch <m@...s.ch>
To:     Kalle Valo <kvalo@...eaurora.org>
Cc:     Colin King <colin.king@...onical.com>,
        linux-wireless@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ssb: make array pwr_info_offset static const, makes
 object smaller

On Fri,  6 Sep 2019 16:40:53 +0100
Colin King <colin.king@...onical.com> wrote:

> diff --git a/drivers/ssb/pci.c b/drivers/ssb/pci.c
> index da2d2ab8104d..7c3ae52f2b15 100644
> --- a/drivers/ssb/pci.c
> +++ b/drivers/ssb/pci.c
> @@ -595,7 +595,7 @@ static void sprom_extract_r8(struct ssb_sprom *out, const u16 *in)
>  {
>  	int i;
>  	u16 o;
> -	u16 pwr_info_offset[] = {
> +	static const u16 pwr_info_offset[] = {
>  		SSB_SROM8_PWR_INFO_CORE0, SSB_SROM8_PWR_INFO_CORE1,
>  		SSB_SROM8_PWR_INFO_CORE2, SSB_SROM8_PWR_INFO_CORE3
>  	};

Thanks for your contribution. This change makes sense.

Kalle, can you please take it?

Acked-by: Michael Büsch <m@...s.ch>

-- 
Michael

Content of type "application/pgp-signature" skipped