linux-kernel - Re: [PATCH] x86/umip: Add emulation for 64-bit processes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <317243DA-3BAE-4620-8E31-5F23145DD992@codeweavers.com>
Date:   Mon, 9 Sep 2019 15:34:28 -0700
From:   Brendan Shanks <bshanks@...eweavers.com>
To:     Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>
Cc:     linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        "Eric W. Biederman" <ebiederm@...ssion.com>
Subject: Re: [PATCH] x86/umip: Add emulation for 64-bit processes


> On Sep 7, 2019, at 2:26 PM, Ricardo Neri <ricardo.neri-calderon@...ux.intel.com> wrote:
> 
> On Thu, Sep 05, 2019 at 04:22:21PM -0700, Brendan Shanks wrote:
>> 
>> 	if (umip_inst == UMIP_INST_SGDT || umip_inst == UMIP_INST_SIDT) {
>> +		u64 dummy_base_addr;
>> +		u16 dummy_limit = 0;
>> +
>> 		/* SGDT and SIDT do not use registers operands. */
>> 		if (X86_MODRM_MOD(insn->modrm.value) == 3)
>> 			return -EINVAL;
>> @@ -228,13 +228,24 @@ static int emulate_umip_insn(struct insn *insn, int umip_inst,
>> 		else
>> 			dummy_base_addr = UMIP_DUMMY_IDT_BASE;
>> 
>> -		*data_size = UMIP_GDT_IDT_LIMIT_SIZE + UMIP_GDT_IDT_BASE_SIZE;
> 
> Maybe a blank line here?

Adding a blank line in place of the removed line? I’m not sure I see the need for it, there’s already a blank line above, and it's followed by the block comment.

Brendan