linux-kernel - Re: [PATCH] driver core: ensure a device has valid node id in device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190910093114.GA19821@kroah.com>
Date:   Tue, 10 Sep 2019 10:31:14 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Yunsheng Lin <linyunsheng@...wei.com>
Cc:     rafael@...nel.org, linux-kernel@...r.kernel.org,
        peterz@...radead.org, mingo@...nel.org, mhocko@...nel.org,
        linuxarm@...wei.com
Subject: Re: [PATCH] driver core: ensure a device has valid node id in
 device_add()

On Tue, Sep 10, 2019 at 02:43:32PM +0800, Yunsheng Lin wrote:
> On 2019/9/9 17:53, Greg KH wrote:
> > On Mon, Sep 09, 2019 at 02:04:23PM +0800, Yunsheng Lin wrote:
> >> Currently a device does not belong to any of the numa nodes
> >> (dev->numa_node is NUMA_NO_NODE) when the node id is neither
> >> specified by fw nor by virtual device layer and the device has
> >> no parent device.
> > 
> > Is this really a problem?
> 
> Not really.
> Someone need to guess the node id when it is not specified, right?

No, why?  Guessing guarantees you will get it wrong on some systems.

Are you seeing real problems because the id is not being set?  What
problem is this fixing that you can actually observe?

thanks,

greg k-h