linux-kernel - Re: [PATCH] scsi: dpt_i2o: drop unnecessary comparison statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADLLry4CjS+1syBCf68BFUbWxZJ8UGcUphinE1Hs7FRvdK0ikg@mail.gmail.com>
Date:   Tue, 10 Sep 2019 20:17:59 +0900
From:   Austin Kim <austindh.kim@...il.com>
To:     aacraid@...rosemi.com, jejb@...ux.ibm.com,
        martin.petersen@...cle.com
Cc:     linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org
Subject: Re: [PATCH] scsi: dpt_i2o: drop unnecessary comparison statement

Hello, Maintainers...
Would you please review this patch and share the feedback?

Thanks,
Austin Kim

2019년 9월 9일 (월) 오후 2:42, Austin Kim <austindh.kim@...il.com>님이 작성:
>
> The type of 'chan' is u32 which contain non-negative value.
> So 'chan < 0' is statment is always false.
>
> Remove unnecessary comparison statement
>
> Signed-off-by: Austin Kim <austindh.kim@...il.com>
> ---
>  drivers/scsi/dpt_i2o.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
> index abc74fd..df48ef5 100644
> --- a/drivers/scsi/dpt_i2o.c
> +++ b/drivers/scsi/dpt_i2o.c
> @@ -1120,7 +1120,7 @@ static struct adpt_device* adpt_find_device(adpt_hba* pHba, u32 chan, u32 id, u6
>  {
>         struct adpt_device* d;
>
> -       if(chan < 0 || chan >= MAX_CHANNEL)
> +       if(chan >= MAX_CHANNEL)
>                 return NULL;
>
>         d = pHba->channel[chan].device[id];
> --
> 2.6.2
>